https://bugs.kde.org/show_bug.cgi?id=353819
Filip Fila <filipfila....@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kde
| |plasma-addons/84742d8965bdc
| |c06fb08601cc11707de1b84e488
Version Fixed In| |5.17
--- Comment #11 from Filip Fila <filipfila....@gmail.com> ---
Git commit 84742d8965bdcc06fb08601cc11707de1b84e488 by Filip Fila.
Committed on 21/06/2019 at 09:38.
Pushed by filipf into branch 'master'.
[Notes] Fix icons being almost invisible with light backgrounds when using dark
themes
Summary:
Old code had no way to adapt icon colors based on background so this patch uses
different components to color the icons black with light backgrounds, and white
with dark backgrounds.
Because Plasma Components 2.0 ToolButton doesn't support icon colors and
because with 3.0 the code doesn't work, we have to port the affected buttons to
QQC2 ToolButton.
FIXED-IN: 5.17
Test Plan:
Before:
{F6808620}
After:
{F6808621}
NOTE: The buttons stay highlighted after being pressed, but I'm trying to solve
that in D21026
Reviewers: #plasma, #vdg, ngraham, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, davidedmundson
Subscribers: broulik, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21027
M +67 -29 applets/notes/package/contents/ui/main.qml
https://commits.kde.org/kdeplasma-addons/84742d8965bdcc06fb08601cc11707de1b84e488
--
You are receiving this mail because:
You are watching all bug changes.
