https://bugs.kde.org/show_bug.cgi?id=408210

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/eli |https://commits.kde.org/eli
                   |sa/50bbbfa301c80d83712fdd10 |sa/fe7d70433b624fe84320725f
                   |e6328692d21e53e9            |36aa27b2e3d2e36c

--- Comment #7 from Nate Graham <n...@kde.org> ---
Git commit fe7d70433b624fe84320725f36aa27b2e3d2e36c by Nate Graham.
Committed on 06/06/2019 at 21:00.
Pushed by ngraham into branch 'master'.

Make Playlist items span full width

Summary:
Currently playlist items do not span the full width; there is a bunch of
complicated logic to determine the margins and playlist's width. This
makes the display look unbalanced and causes a subtle visual bug
(see BUG: below).

This patch resolves both issues by making playlist items visually stick to
both edges of the playlist, just like the category selector list items do.

This patch also does a bit of necessary code cleanup for the playlist states.
I tested this out quite a bit but to make sure there were no regressions but
it's possible that I missed something so more testing may be needed.

Test Plan:
Before: {F6871989}

After: {F6871988}

Reviewers: mgallien, #elisa

Reviewed By: mgallien, #elisa

Subscribers: januz

Differential Revision: https://phabricator.kde.org/D21582

M  +1    -18   src/qml/ContentView.qml
M  +5    -0    src/qml/MediaPlayListView.qml
M  +7    -3    src/qml/PlayListAlbumHeader.qml
M  +3    -2    src/qml/PlayListEntry.qml

https://commits.kde.org/elisa/fe7d70433b624fe84320725f36aa27b2e3d2e36c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to