https://bugs.kde.org/show_bug.cgi?id=398228

atulbi <atulbish...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-desktop/3e0fd10ddc27480
                   |                            |dcd01767ddb0ab698948228bd

--- Comment #8 from atulbi <atulbish...@gmail.com> ---
Git commit 3e0fd10ddc27480dcd01767ddb0ab698948228bd by Atul bisht.
Committed on 18/05/2019 at 15:28.
Pushed by atulbi into branch 'Plasma/5.16'.

[Touchpad KCM] Fixed loading of wrong qml file

Summary:
On system settings, If Mouse KCM is opened first, then touchpad KCM loads the
same Mouse QML file (qrc:/libinput/main.qml) instead of Touchpad Qml file.
Having same url (qrc:/libinput/main.qml).

Fix: simply renaming qml files fixed the issue.There could be better solutions
though.

Also removed unused configProps from D21228.

Test Plan:
1. Renamed main.qml to touchpad.qml .
2. Edited resource file to reflect change.
3. When compiled with these changes and opened touchpad setting, it was all
blank, which was expected (because i did not changed the source).But opening
mouse and then
touchpad shows mouse settigs. So it Confirmed the cause.
4. Now changing source and compiling it fixes the issue. Now, no more mouse on
Touchpad and vice-versa.

Reviewers: romangg, ngraham

Reviewed By: romangg

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21269

M  +1    -1    CMakeLists.txt
M  +0    -23   kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
R  +0    -0    kcms/touchpad/src/kcm/libinput/touchpad.qml [from:
kcms/touchpad/src/kcm/libinput/main.qml - 100% similarity]
M  +1    -1    kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
M  +1    -1    kcms/touchpad/src/kcm/resources.qrc

https://commits.kde.org/plasma-desktop/3e0fd10ddc27480dcd01767ddb0ab698948228bd

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to