https://bugs.kde.org/show_bug.cgi?id=403064

David Hallas <da...@davidhallas.dk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/78540e49213ed1a03687d5
                   |                            |5063816659c9142eba

--- Comment #7 from David Hallas <da...@davidhallas.dk> ---
Git commit 78540e49213ed1a03687d55063816659c9142eba by David Hallas.
Committed on 13/05/2019 at 14:58.
Pushed by hallas into branch 'master'.

Summary: Fixes crash when hiding devices

Summary:
Fixes crash when hiding devices. The crash is caused by
KStandardItem::setDataValue which calls the
KStandardItemModel::onItemChanged function, and that function will
delete the KStandardItem if the data value being set is the hidden
attribute being set to true. To fix this KStandardItem now derives
QObject so that we can use deleteLater.

Test Plan:
Right click a device in the places panel and select hide
Right click the places panel and select show hidden
Right click the hidden device and select show
Right click the same device and select hide

Reviewers: #dolphin, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D21050

M  +3    -30   src/kitemviews/kstandarditem.cpp
M  +3    -11   src/kitemviews/kstandarditem.h
M  +1    -1    src/kitemviews/kstandarditemmodel.cpp

https://commits.kde.org/dolphin/78540e49213ed1a03687d55063816659c9142eba

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to