https://bugs.kde.org/show_bug.cgi?id=376813
Christoph Feck <cf...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Version Fixed In| |5.15.5
Latest Commit| |https://commits.kde.org/kwi
| |n/57440d1d6b490cdad51266977
| |d0269a08918b82f
--- Comment #11 from Christoph Feck <cf...@kde.org> ---
Git commit 57440d1d6b490cdad51266977d0269a08918b82f by Christoph Feck.
Committed on 26/04/2019 at 08:52.
Pushed by cfeck into branch 'Plasma/5.15'.
Fix captions with non-BMP characters
KWin replaces any non-printable character with a space. This check does not
handle surrogate pairs correctly. Additionally, translators sometimes insert
non-printable soft-hyphens into titles, which also cause KWin to display a
space instead.
This code adds the missing surrogate handling, and (to fix both issues), also
removes non-printable characters instead of replacing them with a space.
Also moved the changed test after these changes, so that changes in non-
printable characters do not cause unneeded redraws.
Unit tests adapted by Vlad Zagorodniy.
Test Plan:
kwrite /tmp/Test😣.txt shows correct title. I also tested actual non-printable
characters, such as 0x1A, and these are correctly omitted.
FIXED-IN: 5.15.5
Reviewers: #kwin, zzag
Reviewed By: #kwin, zzag
Subscribers: zzag, grasslin, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D19052
M +20 -9 autotests/integration/x11_client_test.cpp
M +19 -5 client.cpp
https://commits.kde.org/kwin/57440d1d6b490cdad51266977d0269a08918b82f
--
You are receiving this mail because:
You are watching all bug changes.
