https://bugs.kde.org/show_bug.cgi?id=391108
Dan Jensen <ad...@leinir.dk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kne
| |wstuff/e1f5782a85186cc61c5a
| |d55faa33ad5fdae729a9
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Dan Jensen <ad...@leinir.dk> ---
Git commit e1f5782a85186cc61c5ad55faa33ad5fdae729a9 by Dan Leinir Turthra
Jensen.
Committed on 25/04/2019 at 10:07.
Pushed by leinir into branch 'master'.
Remove pixelated border
Summary:
In the before-times, drop shadows were considered vitally important on
everything, and so it was introduced to KNewStuff's dialogues as well. It was,
however, never done quite right, and it's making our dialogues look all silly.
So, we remove it for now, and if we still want it, we can reintroduce them in a
more modern fashion.
Test Plan:
Open the details dialogue of any knewstuff listing
Before patch: See pixelated (and weirdly positioned) pixelated border on all
preview images
After patch: See no pixelated border
Reviewers: #knewstuff, ngraham, sitter, #vdg
Reviewed By: ngraham, #vdg
Subscribers: anthonyfieroni, mmustac, ndavis, kde-frameworks-devel, #knewstuff
Tags: #frameworks, #knewstuff
Differential Revision: https://phabricator.kde.org/D20693
M +0 -4 data/CMakeLists.txt
D +- -- data/thumb_frame.png
M +0 -4 src/ui/imagepreviewwidget.cpp
M +0 -1 src/ui/imagepreviewwidget_p.h
https://commits.kde.org/knewstuff/e1f5782a85186cc61c5ad55faa33ad5fdae729a9
--
You are receiving this mail because:
You are watching all bug changes.
