https://bugs.kde.org/show_bug.cgi?id=389571
--- Comment #10 from Stefan Brüns <stefan.bru...@rwth-aachen.de> --- Git commit ecf1ae6d0b1691bfe36fc0ff64500f111f3abc32 by Stefan Brüns. Committed on 23/04/2019 at 10:36. Pushed by bruns into branch 'master'. [InformationPanel] Use the new inline configuration mode Summary: The current external configuration dialog has some issues: - its layout is suboptimal, as its initial size is typically to small - it is quite disassociated with the actual widget it configures, properties have a different order, and the property names can be quite abstract without the corresponding value. Doing the visibility selection inline typically avoids the sizing problem, as the containing application (dolphin) is often vertically maximized. The selection becomes more obvious, as the item order is kept, and the values are shown. Depends on D20524 Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20525 M +1 -1 CMakeLists.txt M +0 -1 src/CMakeLists.txt D +0 -102 src/panels/information/filemetadataconfigurationdialog.cpp D +0 -72 src/panels/information/filemetadataconfigurationdialog.h M +6 -8 src/panels/information/informationpanel.cpp M +1 -0 src/panels/information/informationpanel.h M +33 -0 src/panels/information/informationpanelcontent.cpp M +9 -0 src/panels/information/informationpanelcontent.h https://commits.kde.org/dolphin/ecf1ae6d0b1691bfe36fc0ff64500f111f3abc32 -- You are receiving this mail because: You are watching all bug changes.
