https://bugs.kde.org/show_bug.cgi?id=368851

Ragnar Thomsen <rthoms...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |19.04.0
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/ark
                   |                            |/3a21006fa55ca5d382eb8de87b
                   |                            |39b7d8ca902e02

--- Comment #8 from Ragnar Thomsen <rthoms...@gmail.com> ---
Git commit 3a21006fa55ca5d382eb8de87b39b7d8ca902e02 by Ragnar Thomsen.
Committed on 07/04/2019 at 17:34.
Pushed by rthomsen into branch 'Applications/19.04'.

Handle locked RAR archives

RAR archives can have a "locked" property essentially making them
readonly. Currently, Ark doesn't handle this properly and fails silently
if the user tries to modify the archive (e.g. adding files).

This diff adds a virtual method ReadOnlyArchiveInterface::isLocked()
with a default implementation returning false. The method is overridden
by the RAR plugin which checks if the archive is locked when listing.
ReadWriteArchiveInterface::isReadOnly() checks isLocked() when
determining the readonly status of the archive.
FIXED-IN: 19.04.0
Differential Revision: D20122

M  +7    -0    autotests/plugins/clirarplugin/clirartest.cpp
A  +-    --    autotests/plugins/clirarplugin/data/locked_archive.rar
M  +9    -0    kerfuffle/archiveinterface.cpp
M  +5    -0    kerfuffle/archiveinterface.h
M  +11   -0    plugins/clirarplugin/cliplugin.cpp
M  +2    -0    plugins/clirarplugin/cliplugin.h

https://commits.kde.org/ark/3a21006fa55ca5d382eb8de87b39b7d8ca902e02

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to