https://bugs.kde.org/show_bug.cgi?id=360435
--- Comment #17 from allan <agande...@gmail.com> --- (In reply to NSLW from comment #16) > (In reply to allan from comment #15) > > Unfortunately, I am unable to follow the detail of the latest proposed > > patch, but I would like to urge some caution. It may be that the proposal > > does not affect the config file - csvimporterrc, but in its current > > implementation, it is possible for the user to edit the entries in the file > > to suit his needs. If instead the entries are moved into the coding, then > > recompilation would be required for any changes, which most users would not > > wish to face. If this is not the case, then that's fine. > > The second version of the patch is different from the first you've committed > only in asking m_map for security name using its symbol in uppercase instead > of lowercase, because m_map is from now on filled by default with symbols in > uppercase and m_map won't return correct name if asked in lowercase. > > AFAIK no part of csvimporterrc shouldn't impact the behavior changed here. > In fact we make the behavior lax, so user can in any time change his symbol > from uppercase to lowercase or mixed case and still get it detected as the > same symbol. > > If that's fine I think I can apply second version of patch just like you've > applied the first one. That sounds good to me. Would you check on the Frameworks side please, as Christian committed only my 'partial' patch. -- You are receiving this mail because: You are watching all bug changes.
