https://bugs.kde.org/show_bug.cgi?id=385189

Méven Car <meve...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |/bea5b68142e4f018a956fd2174
                   |                            |152d9a3e0679cf
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |5.57
         Resolution|---                         |FIXED

--- Comment #10 from Méven Car <meve...@gmail.com> ---
Git commit bea5b68142e4f018a956fd2174152d9a3e0679cf by Méven Car.
Committed on 28/03/2019 at 21:34.
Pushed by meven into branch 'master'.

KFileWidget In saving single file mode an enter/return press on the
KDirOperator triggers slotOk

Summary:
Draw inspiration from inspiration from https://phabricator.kde.org/D12538 for
reference.

The issue at hand:
 * the KDirOperator did not signal when it received an enter/return event when
it should.
 * This prevents expected behavior
FIXED-IN: 5.57

Test Plan:
1 compile kio and its test kfilewidgettest_saving_gui.cpp
2 launch kfilewidgettest_saving_gui
4 click on an place on the left
5 Hit enter
6 The dialog closes, the filename selected is printed out in the terminal

Reviewers: #frameworks, #dolphin, ngraham, dfaure

Reviewed By: #dolphin, ngraham, dfaure

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19824

M  +2    -0    src/filewidgets/kdiroperator.cpp
M  +6    -0    src/filewidgets/kdiroperator.h
M  +12   -0    src/filewidgets/kfilewidget.cpp
M  +1    -0    src/filewidgets/kfilewidget.h
M  +1    -0    tests/CMakeLists.txt
A  +58   -0    tests/kfilewidgettest_saving_gui.cpp     [License: LGPL (v2+)]

https://commits.kde.org/kio/bea5b68142e4f018a956fd2174152d9a3e0679cf

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to