https://bugs.kde.org/show_bug.cgi?id=404179
Tymond <tamtamy.tym...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kri
| |ta/d7542a79f7f3028227147f4c
| |fba18928694e2961
--- Comment #4 from Tymond <tamtamy.tym...@gmail.com> ---
Git commit d7542a79f7f3028227147f4cfba18928694e2961 by Agata Cacko.
Committed on 26/03/2019 at 18:48.
Pushed by tymond into branch 'master'.
Fix Sequential Iterator assert on invalid rectangles
Summary:
Before Quick Brush engine (roundmarker) was crashing
because Sequential Iterator throwed out asserts
when the rectangle was not "empty" according to Qt
but still not valid (for example has intmin value on
width or height). This commit fixes that behaviour by
providing additional checks.
Commit includes also benchmarks for roundmarker.
Test Plan:
- benchmarks included in the commit
- painting with Quick Brush (i.e. b) Basic-1)
with size <1 px
Reviewers: dkazakov, #krita
Reviewed By: dkazakov, #krita
Subscribers: rempt
Tags: #krita
Differential Revision: https://phabricator.kde.org/D19881
A +- -- benchmarks/data/roundmarker05px.kpp
A +- -- benchmarks/data/roundmarker40px.kpp
M +106 -0 benchmarks/kis_stroke_benchmark.cpp
M +15 -0 benchmarks/kis_stroke_benchmark.h
M +4 -3 libs/global/kis_algebra_2d.cpp
M +28 -2 libs/image/kis_marker_painter.cpp
M +20 -0 libs/image/kis_marker_painter.h
https://commits.kde.org/krita/d7542a79f7f3028227147f4cfba18928694e2961
--
You are receiving this mail because:
You are watching all bug changes.
