https://bugs.kde.org/show_bug.cgi?id=405887

--- Comment #4 from Christophe Giboudeaux <christo...@krop.fr> ---
> but that could break in other ways if ECM's FindFontconfig is not 
> sufficiently compatible with CMake's.

Well, I'm surprised by the CMake's FindFontconfig variables. they don't follow
CMake's standards (FONTCONFIG_FOUND, FONTCONFIG_LIBRARY,
FONTCONFIG_INCLUDE_DIR, FONTCONFIG_VERSION).

https://cmake.org/cmake/help/latest/manual/cmake-developer.7.html#standard-variable-names
suggests they should have the same casing as the ECM module (Fontconfig_FOUND,
Fontconfig_LIBRARIES, Fontconfig_INCLUDE_DIRS, Fontconfig_DEFINITIONS,
Fontconfig_VERSION).

I believe our version is more standard-compliant :)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to