https://bugs.kde.org/show_bug.cgi?id=405796

--- Comment #4 from Alvin Wong <alvinhoc...@gmail.com> ---
So it looks like PyQt5 is now requiring a private copy of the sip module. From
the changelog:

2018-06-17  Phil Thompson  <p...@riverbankcomputing.com>

        * lib/configure.py, rb-product:
        Use a private copy of the sip module. SIP v4.19.9 is now required.
        [7c9bae40b66c]

Simply copying the `sip.pyd` into `PyQt5/` doesn't seem to work (resulted in
`ValueError: PyCapsule_GetPointer called with incorrect name`).

As Ivanyossi pointed out on IRC, according to the docs [1], I need to add
`--sip-module PyQt5.sip` to configure sip. However, in this case it doesn't
install the "legacy" top-level `sip` module unlike what the docs seem to imply,
even though the `--no-module` option wasn't passed.

With this change, Krita can again compile with Python scripting and the scripts
does seem to work. But I can find two places in Krita that tries to `import
sip` [2] [3] and I can't tell if they would be working as expected with this
change.

I also found that Boud had made this change in the past but backed out of it
[4]. Boud, do you remember why you backed out of it?

[1]:
https://www.riverbankcomputing.com/static/Docs/sip/installation.html#ref-private-sip
[2]:
https://github.com/KDE/krita/blob/44080b7b7af892e410bf3bb5b2f19ea785f760fb/plugins/extensions/pykrita/plugin/krita/attic/mikro.py#L30
[3]:
https://github.com/KDE/krita/blob/44080b7b7af892e410bf3bb5b2f19ea785f760fb/plugins/extensions/pykrita/plugin/utilities.cpp#L92
[4]:
https://github.com/KDE/krita/commit/93a2b48e3a0bf1251deaaf84263a76d846c39cef

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to