https://bugs.kde.org/show_bug.cgi?id=373430

Igor Poboiko <igor.pobo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/bal
                   |                            |oo/e58804bf9eb8d507d3ef4aa8
                   |                            |faf12d6854f5a8bc
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #9 from Igor Poboiko <igor.pobo...@gmail.com> ---
Git commit e58804bf9eb8d507d3ef4aa8faf12d6854f5a8bc by Igor Poboiko.
Committed on 20/03/2019 at 09:01.
Pushed by poboiko into branch 'master'.

React to config updates inside indexer

Summary:
In case a config was changed, we need to:
 1. Stop the ContentIndexer (bug 373430)
 2. Remove all scheduled indexing of files that should not be indexed
 3. Check for stale index entries. Those includes documents marked for
indexing, that should be removed
(because of that we need to do it inside `scheduleIndexing` before content
indexing)
 4. Finally, check for unindexed files (if new files were added)

(based on {D15939}). Also note that `IndexCleaner` should clean all files, not
just those inside `includeFolders`

Test Plan:
Seems to be working. But it would be nice to test it more.

 1. Add large folder to config. `baloo_file` start indexing it.
 2. Add it to exclude list. `baloo_file` stops indexing it, and removes entries
from DB.
 3. Remove it from exclude list. `baloo_file` starts indexing it again.

Reviewers: #baloo, #frameworks, bruns, ngraham

Reviewed By: #baloo, ngraham

Subscribers: kde-frameworks-devel, bruns

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D15983

M  +38   -10   src/file/fileindexscheduler.cpp
M  +1    -0    src/file/fileindexscheduler.h
M  +7    -0    src/file/indexcleaner.cpp
M  +1    -2    src/file/mainhub.cpp

https://commits.kde.org/baloo/e58804bf9eb8d507d3ef4aa8faf12d6854f5a8bc

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to