https://bugs.kde.org/show_bug.cgi?id=403703

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/2003b267d4bcc
                   |                            |6d0d2bee585d9da0c0abde6e85d
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.16.0

--- Comment #11 from Nate Graham <n...@kde.org> ---
Git commit 2003b267d4bcc6d0d2bee585d9da0c0abde6e85d by Nate Graham, on behalf
of David Redondo.
Committed on 09/03/2019 at 16:05.
Pushed by ngraham into branch 'master'.

Image Wallpaper Slideshow - display the list of images that will be shown

Summary:
This shows all the pictures inside the folders added to the Folders list. I
also tried to make single pictures excludable via a checkbox on the thumbnail.
This is the first time for me programming with QT/QML/Singals-Slots and I tried
to use as much existing code as possible. The thumbnail view is the same as for
single images and I simply subclassed the listmodel. However even if I tried to
do everything like the code for slidePaths it doesn't work correctly. The
checking/unchecking of images only applies on restart of plasmashell. Maybe
it's a single mistake that is easily spotted by a more experienced programmer
otherwise if the thumbnail view is accepted I can also revert all the checkbox
stuff.
FIXED-IN: 5.16.0

{F6595564}

Reviewers: #vdg, ngraham, davidedmundson

Reviewed By: #vdg, ngraham, davidedmundson

Subscribers: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18809

M  +1    -0    wallpapers/image/CMakeLists.txt
M  +5    -3    wallpapers/image/backgroundlistmodel.h
M  +43   -3    wallpapers/image/image.cpp
M  +6    -1    wallpapers/image/image.h
M  +5    -5    wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
M  +65   -30   wallpapers/image/imagepackage/contents/ui/config.qml
A  +44   -0    wallpapers/image/slidemodel.cpp     [License: UNKNOWN]  *
A  +19   -0    wallpapers/image/slidemodel.h     [License: UNKNOWN]  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://commits.kde.org/plasma-workspace/2003b267d4bcc6d0d2bee585d9da0c0abde6e85d

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to