https://bugs.kde.org/show_bug.cgi?id=63151
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/spe
| |ctacle/9561610552c78ae7cd9d
| |ce572ca7d241765532c1
Version Fixed In| |19.04.0
Status|CONFIRMED |RESOLVED
--- Comment #10 from Nate Graham <n...@kde.org> ---
Git commit 9561610552c78ae7cd9dce572ca7d241765532c1 by Nate Graham, on behalf
of Nils Rother.
Committed on 07/03/2019 at 20:36.
Pushed by ngraham into branch 'master'.
Add Compression Quality slider for lossy formats
Summary:
FIXED-IN: 19.04.0
This adds a slider to set the compression quality for lossy file formats
to the settings page, so users can set it themselves instead of having
to just accept the (in my opinion too low) default value.
The slider defaults to a quality level of 90.
A couple of notes:
-When adding the slider to the 'Save'-page layout I noticed that the
bottom of the help text for the filename chooser got cut off because
the window was too small. I tried to figure out how to get the settings
page to scroll but couldn't quite get it working. Instead I resorted to
simply increasing the default size of the settings window just enough to
make it
fit. If someone with more experience in Qt than me can get the page to
scroll OR
can suggest a better way to display the formatting help text (which I feel
takes up too much of the page), that would be marvelous.
-When saving an image at full (100) quality it still looks a bit washed out
and
fuzzy, when compared to, for example, saving the image as png and converting
it
to JPG in gimp at full quality. This might be an issue with QImageWriter
unless
this is the desired behaviour? I haven't looked into it too much, just
something
I've noticed when testing
Test Plan:
This setting can be found under
Configure -> Save -> Compression Quality
{F6669261}
Set the default file type to JPG, adjust the slider and export to an
image-viewer
of your choosing (eg. feh) to see how it affects image quality.
Reviewers: #vdg, #spectacle, davidre, ngraham
Reviewed By: #vdg, #spectacle, davidre, ngraham
Subscribers: ngraham, davidre, #spectacle
Tags: #spectacle
Differential Revision: https://phabricator.kde.org/D19591
M +1 -0 src/ExportManager.cpp
M +36 -0 src/Gui/SettingsDialog/SaveOptionsPage.cpp
M +2 -2 src/Gui/SettingsDialog/SaveOptionsPage.h
M +1 -1 src/Gui/SettingsDialog/SettingsDialog.cpp
M +13 -0 src/SpectacleConfig.cpp
M +3 -0 src/SpectacleConfig.h
https://commits.kde.org/spectacle/9561610552c78ae7cd9dce572ca7d241765532c1
--
You are receiving this mail because:
You are watching all bug changes.
