https://bugs.kde.org/show_bug.cgi?id=389119

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/fil
                   |                            |elight/4cc7c44589f07f0f5294
                   |                            |f8ed6f0b71d20699cd1e

--- Comment #3 from Harald Sitter <sit...@kde.org> ---
Git commit 4cc7c44589f07f0f5294f8ed6f0b71d20699cd1e by Harald Sitter, on behalf
of Szymon Janus.
Committed on 04/03/2019 at 16:12.
Pushed by sitter into branch 'Applications/18.12'.

Fix use after free in RadialMap::Widget::invalidate()

Summary:
Emit aboutToEmptyCache to invoke RadialMap::Widget::invalidate(),
so folder can be safely deleted.

If "Scan across system boundaries" isn't set and there is mountpoint B
contained in another mountpoint A, user may trigger segfault if scan of
A and then B is requested. It is caused by call of MainWindow class to
m_map->invalidate() method, which is invoked after m_map's m_tree member
is deleted during ScanManager::start method.

This fix causes that RadialMap::Widget::invalidate() is called twice in
fact, however second call is fine, because "invalidate" is guarded by
"isValid" method.

Reviewers: sitter, sandsmark

Reviewed By: sitter

Subscribers: kde-utils-devel

Differential Revision: https://phabricator.kde.org/D11188

M  +1    -0    src/scan.cpp

https://commits.kde.org/filelight/4cc7c44589f07f0f5294f8ed6f0b71d20699cd1e

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to