https://bugs.kde.org/show_bug.cgi?id=402487
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Version Fixed In| |5.16.0
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/74f0f25946554
| |3e52ad93aed2d2fb8471c9f9777
--- Comment #8 from Nate Graham <n...@kde.org> ---
Git commit 74f0f259465543e52ad93aed2d2fb8471c9f9777 by Nate Graham.
Committed on 28/02/2019 at 21:36.
Pushed by ngraham into branch 'master'.
[Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox
Summary:
The use of a tri-state checkbox for the three possible states (12hr, 24hr, use
locale
default) is not ideal because it violates the convention regarding what
tri-state
checkboxes are used for: nested lists where some sub-items can be unselected.
This patch replaces it with a combobox that clearly indicates all three states.
While we're at it, we add a button to open the Formats KCM in case people want
to change their region.
FIXED-IN: 5.16.0
Test Plan:
Tested functionality with `en_US` locale. Check out the clock in the
bottom-right corner of
the following screenshots:
Default state: "Use Region Defaults": {F6645570}
Force 12 hour time: {F6645573}
Force 24-hour time: {F6645574}
Reviewers: #plasma, Zren, #vdg, davidedmundson, ndavis
Reviewed By: #plasma, #vdg, davidedmundson, ndavis
Subscribers: cfeck, totte, ndavis, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19230
M +27 -7 applets/digital-clock/package/contents/ui/configAppearance.qml
https://commits.kde.org/plasma-workspace/74f0f259465543e52ad93aed2d2fb8471c9f9777
--
You are receiving this mail because:
You are watching all bug changes.
