https://bugs.kde.org/show_bug.cgi?id=378051
David Hallas <da...@davidhallas.dk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kio
| |/f56af9e2ea0aa61d3faa9c57aa
| |477016b1223f96
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #10 from David Hallas <da...@davidhallas.dk> ---
Git commit f56af9e2ea0aa61d3faa9c57aa477016b1223f96 by David Hallas.
Committed on 25/02/2019 at 10:07.
Pushed by hallas into branch 'master'.
Fix crash in Dolphin when dropping trashed file in trash
Summary:
Fix crash in Dolphin when dropping trashed file in trash. The actual
crash happens because of an assertion failure in kcoredirlister_p.h:308
and this is triggered from kcoredirlister.cpp:995. What actually happens
is that the dropjob determines that it should perform a move action
which ends up being a rename operation for kio_trash. But it ends up
moving the file to itself and this triggers the above crash. The
solution is to error out in the dropjob with a KIO::ERR_DROP_ON_ITSELF
error so that the user can see that it doesn't make sense to drop a
file from the trash inside the trash again.
Test Plan:
Put a file in trash
Drag and drop the file to the trash
Reviewers: #frameworks, elvisangelaccio, ngraham, dfaure
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D19168
M +25 -0 autotests/dropjobtest.cpp
M +4 -0 src/widgets/dropjob.cpp
https://commits.kde.org/kio/f56af9e2ea0aa61d3faa9c57aa477016b1223f96
--
You are receiving this mail because:
You are watching all bug changes.
