https://bugs.kde.org/show_bug.cgi?id=396011
Fabian Vogt <fab...@ritter-vogt.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kde
| |clarative/856672f370fb32c7a
| |3c3d1a13d873fb8b767d0e8
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #25 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit 856672f370fb32c7a3c3d1a13d873fb8b767d0e8 by Fabian Vogt, on behalf
of Tranter Madi.
Committed on 05/02/2019 at 18:55.
Pushed by fvogt into branch 'master'.
Correct the accept flag of the event object on DragMove
Summary:
- `m_enabled` or `m_temporaryInhibition` could change while DragMove, so we
should place `setAccepted()` on top of the function body. Otherwise, the accept
flag of `event` could be wrong in the case `m_enabled` or
`m_temporaryInhibition` changes while DragMove.
- Don't call `setAccepted(false)` wrongly if `event->pos() ==
m_oldDragMovePo`
Test Plan:
- Drag a file from Dolphin -> Desktop (Desktop containment layout) -> too
difficult -> fixed
- Drag an icon on Desktop (Folder view layout) from one place to another one ->
too difficult -> fixed
- Add widgets to the Plasma panel -> too difficult -> fixed
- Drag a file from Dolphin -> Desktop (Folder view layout) -> still easy
Reviewers: mart, broulik, #plasma, hein, bruns
Reviewed By: mart, #plasma
Subscribers: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D16643
M +2 -3 src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp
https://commits.kde.org/kdeclarative/856672f370fb32c7a3c3d1a13d873fb8b767d0e8
--
You are receiving this mail because:
You are watching all bug changes.
