https://bugs.kde.org/show_bug.cgi?id=397125

Luigi Toscano <luigi.tosc...@tiscali.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/pri
                   |                            |nt-manager/9fc009743a32738b
                   |                            |5f585a826a370f3ee6a1c408
             Status|REPORTED                    |RESOLVED

--- Comment #13 from Luigi Toscano <luigi.tosc...@tiscali.it> ---
Git commit 9fc009743a32738b5f585a826a370f3ee6a1c408 by Luigi Toscano, on behalf
of Michael Weghorn.
Committed on 02/02/2019 at 00:34.
Pushed by ltoscano into branch 'master'.

Show more information on CUPS auth dialog

Summary:
This extends 'KCupsPasswordDialog' so that a prompt text can be
set.
It is explicitly stated that authentication is required
by CUPS, which was not totally clear beforehand and
prompt information as passed via the CUPS
callback function is displayed in addition.

This e.g. makes clear what host the authentication
information is sent to.

Test Plan:
Set up a remote CUPS server that requires authentication
and modify '~/.cups/client.conf' so that it points to this server,
e.g. as described in https://bugs.kde.org/show_bug.cgi?id=397125#c6 .

Start print-manager and make sure the authentication dialog is clear
what the authentication is needed for and where the information is sent.

Reviewers: dantti, ngraham

Reviewed By: dantti, ngraham

Subscribers: ltoscano, ngraham, kde-utils-devel

Differential Revision: https://phabricator.kde.org/D18648

M  +3    -1    libkcups/KCupsConnection.cpp
M  +9    -2    libkcups/KCupsPasswordDialog.cpp
M  +2    -0    libkcups/KCupsPasswordDialog.h

https://commits.kde.org/print-manager/9fc009743a32738b5f585a826a370f3ee6a1c408

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to