https://bugs.kde.org/show_bug.cgi?id=403736
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/qqc
| |2-desktop-style/152bb7363a8
| |03a8099367cc7f423b9b8180f0b
| |a4
--- Comment #1 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 152bb7363a803a8099367cc7f423b9b8180f0ba4 by David Edmundson.
Committed on 30/01/2019 at 01:55.
Pushed by davidedmundson into branch 'master'.
Fix combobox initial sizing
Summary:
We have a listview in a popup. The popup is resized to the listview
content height.
Because the popup starts out at size 0 the listview thinks it's too
small to show anything.
So it doesn't load any delegates.
As it has no delegates it can't guess the contentHeight.
contentHeight is a guess based on count * (currentHeight
/ currentlyLoadedDelegates)
That means the popup doesn't resize properly.
Ultimately it does end up showing a two entries, but it doesn't
re-evaluate the contentHeight properly to resize the popup correctly.
Forcing it to load one delegate is enough to break that cycle.
Test Plan:
Opened popup in cursortheme and fonts
Worked correctly
Reviewers: #plasma, mart, ngraham
Reviewed By: #plasma, mart, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18597
M +5 -0 org.kde.desktop/ComboBox.qml
https://commits.kde.org/qqc2-desktop-style/152bb7363a803a8099367cc7f423b9b8180f0ba4
--
You are receiving this mail because:
You are watching all bug changes.
