https://bugs.kde.org/show_bug.cgi?id=403358

--- Comment #4 from Michail Vourlakos <mvourla...@gmail.com> ---
(In reply to Steffen Coenen from comment #3)
> I made some changes for my own usage that fix Latte with Plasma 5.14.90, but
> I think they would break it with earlier Plasma versions:
> https://github.com/Tar-Dingens/latte-dock/commit/
> 47fb713422bd0a81f3c452479c2b16930d01c59c
> https://github.com/Tar-Dingens/latte-dock/commit/
> a93d94437d3693d74186fae5f68ae7b1648b4445
> 
> Original commit in plasma-desktop:
> https://github.com/KDE/plasma-desktop/commit/
> b0d6eab4a698809ff9f5b7244a975ac467222508

yes you are right, this is probably because of the new changes in
libtaskmanager in plasma 5.15 . Latte has a way to handle this because it can
catch the plasma version, it can do this with:

Latte.WindowSystem.plasmaDesktopVersion >=
Latte.WindowSystem.makeVersion(5,14,90)

breaking compatibility with previous versions at this stage I think it would be
disastrous because there are many users using git verstion and that would break
their systems.

Do you think it would be possible to make one-two PRs based on the above
approach? This way you could verify that it works in your system and I can
verify that it works for plasma<5.15

What I have in my mind is this, at plasmoid: main.qml file there could be a
bool variable:

property bool plasma515: Latte.WindowSystem.plasmaDesktopVersion >=
Latte.WindowSystem.makeVersion(5,14,90)


after that all the needed changes can just check "root.plasma515" in order to
decide which options to use or not from libtaskmanager


This will be needed for Latte v0.8 also so this commits could be also be
applied at v0.8 branch afterwards

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to