https://bugs.kde.org/show_bug.cgi?id=403153

--- Comment #2 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit c4a35f5e36bd5d5814b7288e991e125792e24d2c by David Edmundson.
Committed on 16/01/2019 at 12:45.
Pushed by davidedmundson into branch 'master'.

Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets

Summary:
See the end of QComboBox::initStyleOption

    if (d->container && d->container->isVisible())
        option->state |= QStyle::State_On;

The relevant breeze code reads:

        const bool hasFocus( enabled && ( state & (State_HasFocus |
State_Sunken ) ) );
        const bool sunken( state & (State_On|State_Sunken) );

So we still remain sunken in breeze, but we don't assume hasFocus, which
gives the background an incorrect colour.

Test Plan:
Ran testComboBox from Aleix
Debug inside Breeze QStyle + reading Qt code

Reviewers: broulik

Reviewed By: broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18284

M  +1    -2    org.kde.desktop/ComboBox.qml

https://commits.kde.org/qqc2-desktop-style/c4a35f5e36bd5d5814b7288e991e125792e24d2c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to