https://bugs.kde.org/show_bug.cgi?id=396725
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Version Fixed In| |5.15.0
Latest Commit| |https://commits.kde.org/kwi
| |n/d28827626931ed9f8fbfd618b
| |bdcdf3fdce6a5e6
Status|CONFIRMED |RESOLVED
--- Comment #7 from Nate Graham <n...@kde.org> ---
Git commit d28827626931ed9f8fbfd618bbdcdf3fdce6a5e6 by Nate Graham.
Committed on 06/01/2019 at 23:09.
Pushed by ngraham into branch 'master'.
[kcmkwin/compositing] Port Effects KCM to QQC2
Summary:
This patch ports the Effects KCM to QQC2, which yields the following benefits:
1. General performance enhancements of only using QQC2 rather than a mix of 1
and 2
2. Some code simplification is possible
3. Improves the appearance of the checkable menu items in the dropdown menu,
fixing https://bugs.kde.org/show_bug.cgi?id=402701
4. Improves the appearance when using a fractional scale factor, fixing
https://bugs.kde.org/show_bug.cgi?id=396725
5. Fixes the incorrect size when opened from `kcmshell5`
Along the way, two visual changes are introduced as a by-product of porting:
1. The scrollbar is inline, so it overlaps some of the buttons in the content.
This is somewhat undesirable, but adopting a Kirigami scrollview would fix
this.
2. The button that displays a dropdown menu no longer has a downward-pointing
arrow to indicate as such. This is not my preference, but there's a benefit to
being consistent, and eventually we could can change this in one place to
impeove the appearance of buttons that display dropdown menus everywhere in one
fell swoop.
Related: bug 402701, bug 396076
FIXED-IN: 5.15.0
Test Plan:
All functionality still works
In System Settings, showing improved checkable menu item appearance:
{F6523385}
In `kcmshell` at 1x scale:
{F6523386}
In `kcmshell` at 1.5x scale:
{F6523387}
Reviewers: #kwin, #plasma, davidedmundson
Reviewed By: #kwin, #plasma, davidedmundson
Subscribers: davidedmundson, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D17928
M +60 -63 kcmkwin/kwincompositing/qml/EffectView.qml
https://commits.kde.org/kwin/d28827626931ed9f8fbfd618bbdcdf3fdce6a5e6
--
You are receiving this mail because:
You are watching all bug changes.
