https://bugs.kde.org/show_bug.cgi?id=392753
Jarosław Staniek <stan...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |RESOLVED
Latest Commit|https://commits.kde.org/kex |https://commits.kde.org/kdb
|i/90c3ed3251ddcebee4ac4d2dc |/d1b31bd8a6fc6632f8eeab70b5
|e1c24c857967bd3 |e9a0f1c8630c8f
Version Fixed In|3.2.0 |3.2
--- Comment #6 from Jarosław Staniek <stan...@kde.org> ---
Git commit d1b31bd8a6fc6632f8eeab70b5e9a0f1c8630c8f by Jaroslaw Staniek.
Committed on 06/01/2019 at 21:16.
Pushed by staniek into branch '3.2'.
Fix handling ORDER BY part of queries
Summary:
- new APIs
- maintain relations between connections, queries and column infos
- fix cloning queries with ORDER BY
- update and add autotests
FIXED-IN:3.2
Related: bug 393705
Test Plan:
Required: KEXI & KDb 3.2 (current master)
Test 1: Open report and query from
https://bugs.kde.org/show_bug.cgi?id=392753#c0 in design and data views.
Expected: works, no crashes
Test 2: Try these on a standard Persons and Cars test:
select id from cars order by owner;
select id from cars order by owner, model, id;
select id, model from cars order by 2, 1;
Expected: works, no crash
Reviewers: piggz
Reviewed By: piggz
Subscribers: Kexi-Devel-list
Tags: #kdb
Differential Revision: https://phabricator.kde.org/D12873
M +3 -0 autotests/CMakeLists.txt
A +212 -0 autotests/OrderByColumnTest.cpp [License: LGPL (v2+)]
A +46 -0 autotests/OrderByColumnTest.h [License: LGPL (v2+)]
M +2 -2 src/KDbNativeStatementBuilder.cpp
M +87 -28 src/KDbOrderByColumn.cpp
M +40 -13 src/KDbOrderByColumn.h
M +17 -28 src/KDbQueryColumnInfo.cpp
M +25 -1 src/KDbQueryColumnInfo.h
M +18 -4 src/KDbQuerySchema.cpp
M +29 -1 src/KDbQuerySchema_p.h
https://commits.kde.org/kdb/d1b31bd8a6fc6632f8eeab70b5e9a0f1c8630c8f
--
You are receiving this mail because:
You are watching all bug changes.
