https://bugs.kde.org/show_bug.cgi?id=354802
d0048 <d0...@foxmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |d0...@foxmail.com
--- Comment #28 from d0048 <d0...@foxmail.com> ---
Thanks(In reply to i.Dark_Templar from comment #27)
> (In reply to David Edmundson from comment #25)
> > @i.Dark_Templar
> >
> > There's a potential issue with that patch.
> > If you change dir (such as from configure) we'll get a new completed event.
> >
> > Also I think we can do everything inside plasma-desktop, which skips the
> > need for the buffering and merging
> > https://phabricator.kde.org/P279 - same principle but uses the source model
> > as a buffer before we we set as folder model's proxy.
> >
> > It still needs a fixup as it still has that same issue with handling a
> > directory change.
>
> I think in my patch it's a bit more obvious where data is buffered. I didn't
> test your patch and not sure if it'd actually work, but it looks like it
> might work.
>
> As for issue with changing directory, does folder view store positions
> configuration for different directory somewhere? It doesn't look that way to
> me. But if it's still desired to fix this potential issue, then
> 'started(const QUrl&)' signal from dir lister has to be processed too, and
> for my patch values from qset and qmap for that URL have to be removed, for
> your patch I think source model has to be reset to nullptr to enable
> buffering again.
(In reply to i.Dark_Templar from comment #19)
> I've posted links to patches here for a few reasons. People may try using
> patches and check if it fixes issue for them too and use it if it does fix
> the issue. Or someone may even make better fixes. I did a few improvements
> since originally posting the links.
>
> I might post it to the KDE phabricator later, but KDE devs still can find
> patches here. And posting patches doesn't mean they would be merged into
> upstream KDE anyway. For example of such hanging patch you may see
> https://bugs.kde.org/show_bug.cgi?id=383202
Thanks a lot for the patch coz this bug has been troubling for months. Hope it
will be merge soon. How could I apply the patch manually? Are there any
instructions/documentations I could reference to?
--
You are receiving this mail because:
You are watching all bug changes.
