https://bugs.kde.org/show_bug.cgi?id=402566

Boudewijn Rempt <b...@valdyas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b...@valdyas.org

--- Comment #3 from Boudewijn Rempt <b...@valdyas.org> ---
This change fixes the use of the private api:

@@ -277,15 +281,15 @@ bool KisXMPIO::loadFrom(KisMetaData::Store* store,
QIODevice* ioDevice) const
                 const Exiv2::XmpArrayValue* xav = dynamic_cast<const
Exiv2::XmpArrayValue*>(value.get());
                 Q_ASSERT(xav);
                 QList<KisMetaData::Value> array;
-                for (std::vector< std::string >::const_iterator it =
xav->value_.begin();
-                        it != xav->value_.end(); ++it) {
-                    QString value = it->c_str();
+                for (int i = 0; i == xav->size(); ++i) {
+                    QString value = QString::fromStdString(xav->toString(i));
                     if (parser) {
                         array.push_back(parser->parse(value));
                     } else {
                         dbgImage << "No parser " << tagName;
                         array.push_back(KisMetaData::Value(value));
                     }
+
                 }
                 KisMetaData::Value::ValueType vt =
KisMetaData::Value::Invalid;
                 switch (xav->xmpArrayType()) {
~


The only thing I wonder about is the removal of FindExiv2.cmake and then this
change:


    -target_link_libraries(kritajpegimport kritaui  ${JPEG_LIBRARIES}
${LCMS2_LIBRARIES} ${EXIV2_LIBRARIES} )
    +target_link_libraries(kritajpegimport kritaui  ${JPEG_LIBRARIES}
${LCMS2_LIBRARIES} LibExiv2::LibExiv2 )


Is that really what we want?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to