https://bugs.kde.org/show_bug.cgi?id=385530

Kai Uwe Broulik <k...@privat.broulik.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.14.5
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-browser-integration/904
                   |                            |00518efcd2861ce1b7008f63a57
                   |                            |10ad69e58a
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #4 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit 90400518efcd2861ce1b7008f63a5710ad69e58a by Kai Uwe Broulik.
Committed on 01/12/2018 at 11:48.
Pushed by broulik into branch 'Plasma/5.14'.

Only cancel job when an "error" is set and ignore "interrupted"

In Chrome we get state change to "interrupted" and the error in unison whereas
Firefox first signals
a state change and then updates the error later.

Previously, we would finish the job as soon as it was interrupted leading to a
"unknown error"
any time a download aborted (even if explicitly canceled by the user).

According to documentation the "error" is set in case of an error, so we'll
want to cancel the job in this case.

CHANGELOG: Fixed cancelling download in Firefox showing an "unknown error"
notification
FIXED-IN: 5.14.5

Differential Revision: https://phabricator.kde.org/D17233

M  +57   -59   host/downloadjob.cpp

https://commits.kde.org/plasma-browser-integration/90400518efcd2861ce1b7008f63a5710ad69e58a

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to