https://bugs.kde.org/show_bug.cgi?id=385411

--- Comment #13 from Julian Seward <jsew...@acm.org> ---
(In reply to Andreas Arnez from comment #11)
> Created attachment 116469 [details]
> Tests for vector FP support (v2)
> 
> Revised version of the tests for the vector FP support.  This version
> addresses the feedback from comment #8 and also makes some internal updates
> that had been missing before.

This looks fine to me.  I would suggest running it by hand on Memcheck just to
check that there's no use of uninitialised memory, etc, and also to check that
the instrumentation code that Memcheck generates for these operations is
actually handled by the s390 back end.  OK to commit once that's done.

More generally, it would be advisable also to run, by hand, all of the
none/tests/s390 tests on Memcheck, each four times, for the 4 flag
combinations --track-origins={yes,no} --expensive-definedness-checks={yes,no}.
This has shown up failures on other targets in the past.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to