https://bugs.kde.org/show_bug.cgi?id=400364

Eike Hein <h...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-desktop/ab26ebb18b74d8d
                   |                            |ef8e653dc94516fa7da935a5c
         Resolution|---                         |FIXED
             Status|REPORTED                    |RESOLVED

--- Comment #2 from Eike Hein <h...@kde.org> ---
Git commit ab26ebb18b74d8def8e653dc94516fa7da935a5c by Eike Hein.
Committed on 19/11/2018 at 09:40.
Pushed by hein into branch 'Plasma/5.12'.

Compress calls to `updateSize`

Summary:
Repeater+Flow has no reliable way to transactionize/batch insertion,
e.g. `Flow.positionCompleted` is useless in a function that can change
the Flow's size, and transition events like populated and similar
aren't available. Refactoring this to be a ListView isn't appealing
because it would mean the code loses the property of being reused for
both the bar and the popup, and therefore is well-tested already.

This brings down the number of `updateSize` calls when opening the
dialog for a group of five from five to one.

Reviewers: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17006

M  +4    -4    applets/taskmanager/package/contents/ui/GroupDialog.qml
M  +1    -1    containments/desktop/package/contents/ui/FolderItemDelegate.qml

https://commits.kde.org/plasma-desktop/ab26ebb18b74d8def8e653dc94516fa7da935a5c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to