https://bugs.kde.org/show_bug.cgi?id=360035
--- Comment #8 from Julian Seward <jsew...@acm.org> ---
(In reply to Carl Love from comment #7)
> Created attachment 98176 [details]
> Patch to fix BCD v-bit error
That will work. It is probably possible to generate a faster piece of
code that doesn't require so many PCasts, but if these BCD instructions
are relatively rarely used, that's unlikely to be important.
Only one thing that needs to be changed. You have:
@@ -2892,7 +2917,7 @@ IRAtom* expr2vbits_Triop ( MCEnv* mce,
case Iop_BCDAdd:
case Iop_BCDSub:
complainIfUndefined(mce, atom3, NULL);
- return assignNew('V', mce, Ity_V128, triop(op, vatom1, vatom2,
atom3));
+ return mkLazy3(mce, Ity_V128, vatom1, vatom2, vatom3);
Please remove the complainIfUndefined call. The mkLazy3 call causes any
undefinedness in the 3rd (and 1st and 2nd) args to be propagated into the
result,
so at some point later it will be reported if the result is used to control a
conditional
branch. So there's no point in adding a definedness check at this point too.
--
You are receiving this mail because:
You are watching all bug changes.
