https://bugs.kde.org/show_bug.cgi?id=400359
Fabian Vogt <fab...@ritter-vogt.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
Latest Commit| |https://commits.kde.org/net
| |workmanager-qt/fa472e6a5e26
| |37a681f61e75cf0988bf847f46e
| |d
Resolution|--- |FIXED
--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit fa472e6a5e2637a681f61e75cf0988bf847f46ed by Fabian Vogt.
Committed on 06/11/2018 at 19:17.
Pushed by fvogt into branch 'master'.
Listen for added DBus interfaces instead of registered services
Summary:
When the service is registered, the interfaces might not be available yet.
So wait for those instead.
This was RFC because:
- I'm not sure whether it's guaranteed that InterfacesAdded is emitted on
service registration as well or both connections are necessary
- I don't know how it's possible to test this as org.kde.fakenetwork does
not support the org.freedesktop.ObjectManager API
Test Plan:
Restarting NM while kded5 keeps running caused "nmcli up" to fail because of
missing secrets.
With this patch, it works successfully.
Reviewers: #frameworks, jgrulich
Reviewed By: jgrulich
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D16471
M +16 -8 src/manager.cpp
M +3 -1 src/manager_p.h
M +12 -3 src/secretagent.cpp
M +1 -0 src/secretagent.h
M +1 -1 src/secretagent_p.h
https://commits.kde.org/networkmanager-qt/fa472e6a5e2637a681f61e75cf0988bf847f46ed
--
You are receiving this mail because:
You are watching all bug changes.
