https://bugs.kde.org/show_bug.cgi?id=400632
Dominik Haumann <dhaum...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
Resolution|--- |NOT A BUG
--- Comment #1 from Dominik Haumann <dhaum...@kde.org> ---
The question is what specific problem is addressed with such a potential
change? And the next one, even if we use a unique_ptr and an exception happens,
who will catch the exception? In the Qt and KDE world exceptions are pretty
much not used at all. So if an exception is thrown and no one catches it, the
application will crash just like before.
Using a std::unique_ptr is certainly good practice in certain contexts, e.g.
when using the pimpl approach (the d-pointers). Besides that, it is also common
in Qt to have the parent/child hierarchy, so many objects' lifetime is managed
by the parent QObject; in this case we do not need a unique_ptr at all
typically.
Since there is no particular issue here at hand that needs a fix, I'll close as
"not a bug" for now. If you have patches for KSyntaxHighlighting, KTextEditor,
or Kate, please contact us again best on http://phabricator.kde.org, or for
bugs of course here via the bug tracker :-)
--
You are receiving this mail because:
You are watching all bug changes.
