https://bugs.kde.org/show_bug.cgi?id=269403

Fabian Vogt <fab...@ritter-vogt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kgl
                   |                            |obalaccel/4d28bd4183d20a9bf
                   |                            |f4f50e88cbb47ffef0ede43

--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit 4d28bd4183d20a9bff4f50e88cbb47ffef0ede43 by Fabian Vogt.
Committed on 03/11/2018 at 12:14.
Pushed by fvogt into branch 'master'.

Fix keyboard layout change notifications

Summary:
This rework fixes several issues:
- Qt wasn't informed about XCB_MAPPING_NOTIFY anymore
- With XKB enabled in Qt, X won't send XCB_MAPPING_NOTIFY anymore.
  So listen for XKB events as well.
- Install the event filter before fetching the keysym mapping to
  close a race window
- Use the old mapping for ungrabbing
Related: bug 350816

Test Plan:
Ctrl-Alt-Y global shortcut works even when doing
"setxkbmap us; kglobalaccel5 & sleep 1; setxkbmap de;" while it did not
before. On some systems, this race happened on every login, now it works
reliably.

Reviewers: #frameworks, #plasma, romangg

Reviewed By: #plasma, romangg

Subscribers: romangg, ngraham, anthonyfieroni, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16434

M  +1    -1    CMakeLists.txt
M  +1    -1    src/runtime/plugins/CMakeLists.txt
M  +1    -0    src/runtime/plugins/xcb/CMakeLists.txt
M  +55   -21   src/runtime/plugins/xcb/kglobalaccel_x11.cpp
M  +1    -0    src/runtime/plugins/xcb/kglobalaccel_x11.h

https://commits.kde.org/kglobalaccel/4d28bd4183d20a9bff4f50e88cbb47ffef0ede43

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to