https://bugs.kde.org/show_bug.cgi?id=359767
--- Comment #4 from Julian Seward <jsew...@acm.org> ---
(In reply to Carl Love from comment #1)
> Created attachment 97546 [details]
> patch 1 of 5 to add ISA 3.0 functionality to Valgrind
>
> This is the first patch in a series of five for adding the ISA 3.0
> instruction support to valgrind.
This looks fine. I have only a couple of minor comments:
@@ -833,7 +833,8 @@ VexGuestLayout
/* 7 */ ALWAYSDEFD32(guest_NRADDR_GPR2),
/* 8 */ ALWAYSDEFD32(guest_REDIR_SP),
/* 9 */ ALWAYSDEFD32(guest_REDIR_STACK),
- /* 10 */ ALWAYSDEFD32(guest_IP_AT_SYSCALL)
+ /* 10 */ ALWAYSDEFD32(guest_IP_AT_SYSCALL),
+ /* 11 */ ALWAYSDEFD32(guest_FPCC)
}
};
You need to change .n_alwaysDefd from 11 to 12, else this won't
have any effect.
@@ -874,7 +875,8 @@ VexGuestLayout
/* 7 */ ALWAYSDEFD64(guest_NRADDR_GPR2),
/* 8 */ ALWAYSDEFD64(guest_REDIR_SP),
/* 9 */ ALWAYSDEFD64(guest_REDIR_STACK),
- /* 10 */ ALWAYSDEFD64(guest_IP_AT_SYSCALL)
+ /* 10 */ ALWAYSDEFD64(guest_IP_AT_SYSCALL),
+ /* 11 */ ALWAYSDEFD64(guest_FPCC)
}
};
Same here.
@@ -2785,15 +2786,16 @@ static IRExpr* /* ::Ity_I32 */ getGST_masked ( PPC_GST
reg, UInt mask )
- if (mask & MASK_FPSCR_RN) {
+ if ( mask == MASK_FPSCR_RN ) {
assign( val, unop( Iop_8Uto32, IRExpr_Get( OFFB_FPROUND, Ity_I8 ) )
);
Just a sanity check (I don't really follow the logic here, but ..)
did you really mean to change the guarding condition from
"mask has MASK_FPSCR_RN set" to "mask is exactly equal to MASK_FPSCR_RN" ?
--
You are receiving this mail because:
You are watching all bug changes.
