https://bugs.kde.org/show_bug.cgi?id=364710
Vlad Zagorodniy <vladz...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kwi
| |n/558b86e9f6c08fde10933b3a3
| |c7c126ba287c408
Version Fixed In| |5.14.3
--- Comment #9 from Vlad Zagorodniy <vladz...@gmail.com> ---
Git commit 558b86e9f6c08fde10933b3a3c7c126ba287c408 by Vlad Zagorodniy.
Committed on 30/10/2018 at 20:39.
Pushed by vladz into branch 'Plasma/5.14'.
[effects/desktopgrid] Don't display the close button from Present Windows
Summary:
If you activate the Present Windows effect and then the Desktop Grid,
you'll be able to see the close button from PW. The reason for that is
PW doesn't destroy the close button and DG doesn't filter it out.
This patch addesses this problem by syncing
DesktopGridEffect::isRelevantWithPresentWindows
with PresentWindowsEffect::isSelectableWindow.
On X11, the close button is filtered by the isSpecialWindow check. On
Wayland, the close button is filtered by the acceptsFocus check.
The proposed solution is kinda hack-ish, but on the other hand, we have
to keep those two methods in sync anyway.
In addition to the close button, notifications won't be displayed too.
FIXED-IN: 5.14.3
Test Plan:
* Activate the Present Windows effect;
* Activate the Desktop Grid effect;
* (the close button is no longer visible)
Reviewers: #kwin, graesslin
Reviewed By: #kwin, graesslin
Subscribers: kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D16513
M +25 -2 effects/desktopgrid/desktopgrid.cpp
https://commits.kde.org/kwin/558b86e9f6c08fde10933b3a3c7c126ba287c408
--
You are receiving this mail because:
You are watching all bug changes.
