https://bugs.kde.org/show_bug.cgi?id=349615
--- Comment #5 from Stefan Brüns <stefan.bru...@rwth-aachen.de> --- Git commit 43ab022f35e812b71ab866402c16505aab929529 by Stefan Brüns. Committed on 25/10/2018 at 16:11. Pushed by bruns into branch 'master'. [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp Summary: Baloo uses the metadata change time (stat.st_ctime, man 7 inode) to check for XAttr updates. This field corresponds to QFileInfo::metadataChangeTime(), while created() returns the first available of [birthtime, ctime, mtime]. On filesystems supporting birthtime (XFS, BTRFS) some files were continously reindexed as the BasicIndexingJob stored the ctime, while the UnindexedFileIterator compared the stored value with the btime. On the other hand, XAttr changes where not detected when ctime and btime initially matched, as the btime is fixed. While at it, document the semantics of the two timestamps. Related: bug 397549 Test Plan: 1. watch baloo_file with strace -efile during startup -> files with btime != ctime are indexed just once 2. add a Tag to a file -> file is immediately updated in index, not just after baloo_file restart (e.g. session restart) Reviewers: #baloo, #frameworks, poboiko, ngraham, lbeltrame Reviewed By: lbeltrame Subscribers: lbeltrame, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D16255 M +11 -3 src/engine/documenttimedb.h M +1 -1 src/file/basicindexingjob.cpp M +10 -3 src/file/modifiedfileindexer.cpp M +10 -1 src/file/unindexedfileiterator.cpp https://commits.kde.org/baloo/43ab022f35e812b71ab866402c16505aab929529 -- You are receiving this mail because: You are watching all bug changes.
