https://bugs.kde.org/show_bug.cgi?id=397693

Eike Hein <h...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-desktop/48b32259e73f374
                   |                            |a456ed836ba44e3effe2baee5
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #8 from Eike Hein <h...@kde.org> ---
Git commit 48b32259e73f374a456ed836ba44e3effe2baee5 by Eike Hein.
Committed on 24/10/2018 at 08:01.
Pushed by hein into branch 'master'.

Port Kickoff to shared view component using single-MouseArea pattern

Summary:
This:
* Moves MouseArea out of the item delegate and uses a single MouseArea
  per view.
* Ports all the pages to using a shared view component.

Aside from saving a lot of QObjects, using a single MouseArea also
has the advantage that MouseArea.positionChanged isn't fired when
QQuickWindow synthesizes a hover event per frame, unlike MouseArea
.containsMouse. This fixes a user-reported bug in the search page,
and the same pattern is used by various other UIs we have for
similar reasons.

Reviewers: #plasma, ngraham, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15855

M  +42   -52   applets/kickoff/package/contents/ui/ApplicationsView.qml
M  +21   -34   applets/kickoff/package/contents/ui/BaseView.qml
M  +1    -1    applets/kickoff/package/contents/ui/Breadcrumb.qml
M  +39   -56   applets/kickoff/package/contents/ui/FavoritesView.qml
M  +66   -135  applets/kickoff/package/contents/ui/KickoffItem.qml
A  +170  -0    applets/kickoff/package/contents/ui/KickoffListView.qml    
[License: GPL (v2+)]
M  +23   -33   applets/kickoff/package/contents/ui/SearchView.qml

https://commits.kde.org/plasma-desktop/48b32259e73f374a456ed836ba44e3effe2baee5

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to