https://bugs.kde.org/show_bug.cgi?id=398425
Eike Hein <h...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/yak
| |uake/0c0eb086bdc0a726874a56
| |b46de29fcc73fb792b
--- Comment #2 from Eike Hein <h...@kde.org> ---
Git commit 0c0eb086bdc0a726874a56b46de29fcc73fb792b by Eike Hein, on behalf of
Maximilian Schiller.
Committed on 22/10/2018 at 05:20.
Pushed by hein into branch 'master'.
Use KMainWindow instead of QMainWindow
Summary:
MainWindow should inherit from KMainWindow and not from QMainWindow
because QMainWindow does not call the queryClose function upon closing.
This disabled the "really quit?" dialog which should come up if more than one
session
is currently open.
Furthermore makes Yakuake properly quit when requested via the "Quit" action or
the dialog by
making the QApplication quit if the last Window Closes.
Test Plan:
1. open yakuake
2. press ctrl + shift + q
without the patch yakuake just hides again (press F12 to confirm) with the
patch it properly quits.
1. open yakuake
2. open multiple (>1) sessions (bottom left "+" symbol)
3. press ctrl + shift + q
without the patch yakuake just hides with the patch a dialog comes up and asks
"really quit?"
on pressing "quit" yakuake properly quits.
Reviewers: hein, alexeymin, #kde_applications
Reviewed By: hein
Subscribers: tcanabrava
Differential Revision: https://phabricator.kde.org/D15535
M +16 -9 app/mainwindow.cpp
M +8 -7 app/mainwindow.h
M +14 -14 app/tabbar.h
M +1 -1 app/terminal.h
M +1 -1 app/titlebar.cpp
M +2 -2 app/titlebar.h
M +3 -3 app/visualeventoverlay.h
https://commits.kde.org/yakuake/0c0eb086bdc0a726874a56b46de29fcc73fb792b
--
You are receiving this mail because:
You are watching all bug changes.
