https://bugs.kde.org/show_bug.cgi?id=250355
Michael Pyne <mp...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/juk
| |/e2012e79359854f0ad73769bd0
| |2f092e44f40cf4
Resolution|--- |FIXED
Version Fixed In| |18.08.3
--- Comment #3 from Michael Pyne <mp...@kde.org> ---
Git commit e2012e79359854f0ad73769bd02f092e44f40cf4 by Michael Pyne.
Committed on 20/10/2018 at 02:40.
Pushed by mpyne into branch 'Applications/18.08'.
systray: Make SHIFT+Mousewheel change the volume, not the song.
This fixes a bug that recently hit its 8 year anniversary. :(
The big issue was that there was no easy way to tell which keyboard
modifiers were set for the systray since Qt's event loop didn't actually
receive the keyboard events.
There's a separate function you can call, queryKeyboardModifiers, which
makes a specific query to the desktop, and works even if Qt event loop
didn't receive keyboard events. This fixes the bug here, and hopefully
for everyone else.
In fixing the bug I noticed that we can set out-of-bounds volumes due to
lack of checking, so I fixed that too.
FIXED-IN:18.08.3
M +5 -2 playermanager.cpp
M +1 -1 systemtray.cpp
https://commits.kde.org/juk/e2012e79359854f0ad73769bd02f092e44f40cf4
--
You are receiving this mail because:
You are watching all bug changes.
