https://bugs.kde.org/show_bug.cgi?id=398900
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://cgit.kde.org/kate.g
| |it/commit/?id=d6e38c0cbd3d6
| |d7f7658862757b8c33db4322d7a
Version Fixed In| |18.12.0
Status|REPORTED |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from Nate Graham <n...@kde.org> ---
Great, thanks for testing!
author Tomaz Canabrava <tcanabr...@kde.org> 2018-10-16 14:08:54 (GMT)
committer Tomaz Canabrava <tcanabr...@kde.org> 2018-10-17 10:01:15
(GMT)
commit d6e38c0cbd3d6d7f7658862757b8c33db4322d7a (patch)
tree 30e3b36b4b6c8921eb5613d0b1aa3c2420c14695
parent e2ebc77065c2dae681c5fecf3a1f898e065bc7f6 (diff)
Fix Duplicates on Quick Open File
Summary:
The logic on the quick open was overcomplex, and it led to
bugs while filling the document list.
The new logic fills a vector with all the files,
organizes them by Url, remove the files based on the
duplicated url's (so name matching doesn't matter) and only
then starts to populate the view.
I belive this is also faster than the old code as I minimized
the amount of memory allocations and deallocations.
I'm unsure about the use of QFileInfo in the end of the code as
we can have too many files there and creating a temporary
QFileInfo just to get the name is a huge overhead, we can do a
split('/').last()
for the file name. I'll do some measurements with that.
Reviewers: cullmann, brauch, neundorf
Reviewed By: cullmann
Subscribers: gregormi, dhaumann, kwrite-devel
Tags: #kate
Differential Revision: https://phabricator.kde.org/D15804
--
You are receiving this mail because:
You are watching all bug changes.
