https://bugs.kde.org/show_bug.cgi?id=396790
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
Latest Commit| |https://commits.kde.org/kwi
| |n/99b33e7428d14d9b24689e8cf
| |b23092bf18820c8
Resolution|--- |FIXED
--- Comment #6 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 99b33e7428d14d9b24689e8cfb23092bf18820c8 by David Edmundson.
Committed on 03/10/2018 at 21:57.
Pushed by davidedmundson into branch 'master'.
[libkwineffects] Expose getting/setting activeFullScript to scripted effects
Summary:
Getter is exposed as a property on scripted effect in a way that hides
pointers from the scripting side.
Setter is implicitly handled as a property of newly created animations
and holds the activeFullScreenEffect whilst any of them are active. Like
existing effects it remains up to the effect author to avoid the
problems of multiple full screen effects. The RAII lock pattern is
somewhat overkill currently, but it's the direction I hope we can take
EffectsHandler in next API break.
--
This patch is against the QJSEngine port, though it's not conceptually a
requirement.
Test Plan: Unit test
Reviewers: #kwin, zzag
Reviewed By: #kwin, zzag
Subscribers: zzag, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D14688
M +70 -0 autotests/integration/effects/scripted_effects_test.cpp
A +8 -0 autotests/integration/effects/scripts/fullScreenEffectTest.js
A +22 -0
autotests/integration/effects/scripts/fullScreenEffectTestMulti.js
M +3 -0 autotests/mock_effectshandler.h
M +9 -0 effects.cpp
M +1 -0 effects.h
M +3 -1 libkwineffects/anidata.cpp
M +2 -1 libkwineffects/anidata_p.h
M +24 -4 libkwineffects/kwinanimationeffect.cpp
M +21 -6 libkwineffects/kwinanimationeffect.h
M +16 -0 libkwineffects/kwineffects.h
M +32 -6 scripting/scriptedeffect.cpp
M +10 -2 scripting/scriptedeffect.h
https://commits.kde.org/kwin/99b33e7428d14d9b24689e8cfb23092bf18820c8
--
You are receiving this mail because:
You are watching all bug changes.
