https://bugs.kde.org/show_bug.cgi?id=378914
Karl Ove Hufthammer <k...@huftis.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kpa
| |t/eb5fa8dab3559bf008829154c
| |4c17239af607da6
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Version Fixed In| |18.08.2
--- Comment #2 from Karl Ove Hufthammer <k...@huftis.org> ---
Git commit eb5fa8dab3559bf008829154c4c17239af607da6 by Karl Ove Hufthammer.
Committed on 20/09/2018 at 18:00.
Pushed by huftis into branch 'Applications/18.08'.
Reduce wasted space for Klondike and Grandfather
Summary:
Klondike and (especially) Grandfather reserves a lot of
space at the bottom of the screen for long card piles.
This results in very small cards, which makes the game
uncomfortable to play, especially on smaller screens.
This commmit reduces the space reserved at the bottom
of the screen, which automatically enlarges the cards.
Long piles don’t pose a problem, as KPat automatically
compresses the cards to fit the screen.
Even with the reduced space, the colours and numbers are
still clearly visible, also in a ‘worst case’ scenario with very
long piles. (In these two game types, only the colour
(i.e. red vs. black) matter, not the suit, so it is not a
problem if the suits of the cards aren’t visible.)
Related: bug 307625
FIXED-IN: 18.08.2
Test Plan:
Play Grandfather and Klondike before and after this patch.
Note that the cards are much bigger after the patch
and that the numbers and colours are still clearly visible.
Reviewers: #kde_games, fabiank, mlaurent
Reviewed By: fabiank
Subscribers: kde-games-devel
Differential Revision: https://phabricator.kde.org/D15534
M +1 -1 grandf.cpp
M +1 -1 klondike.cpp
https://commits.kde.org/kpat/eb5fa8dab3559bf008829154c4c17239af607da6
--
You are receiving this mail because:
You are watching all bug changes.
