https://bugs.kde.org/show_bug.cgi?id=382075

Andrew Crouthamel <andrew.croutha...@kdemail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kte
                   |                            |xteditor/d67dd570336e995ea4
                   |                            |a7f2fbfcd47d05ad3a0eae
             Status|CONFIRMED                   |RESOLVED

--- Comment #6 from Andrew Crouthamel <andrew.croutha...@kdemail.net> ---
Git commit d67dd570336e995ea4a7f2fbfcd47d05ad3a0eae by Andrew Crouthamel.
Committed on 07/09/2018 at 23:25.
Pushed by acrouthamel into branch 'master'.

Fix Solarized Light and Dark color schemes

Summary:
Solarized Light contrast was low. Upon investigation it was determined much of
the color scheme did not follow Solarized base 16 colors or rules. Color scheme
for both Dark and Light variants were adjusted to match the latest Solarized
color scheme release palette and [[
https://ethanschoonover.com/solarized/#usage-development | color interaction
rules ]]. Color schemes were also matched closely to the [[
https://github.com/altercation/vim-colors-solarized/blob/master/colors/solarized.vim
| Vim color scheme ]] created by the original Solarized author.

This is my first "frameworks" patch, so please let me know if I missed
anything.

This has also been added to KSyntaxHighlighting in D15340.

Solarized Light Before:
{F6241106}
Solarized Light After:
{F6241107}
Solarized Dark Before:
{F6241108}
Solarized Dark After:
{F6241109}

Test Plan: Open Kate with new rc files and inspect the Color settings. Open a
CPP file to review syntax highlighting.

Reviewers: #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann

Reviewed By: #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann

Subscribers: dhaumann, kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks, #ktexteditor

Differential Revision: https://phabricator.kde.org/D15337

M  +9    -9    src/data/kateschemarc
M  +56   -38   src/data/katesyntaxhighlightingrc

https://commits.kde.org/ktexteditor/d67dd570336e995ea4a7f2fbfcd47d05ad3a0eae

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to