https://bugs.kde.org/show_bug.cgi?id=398066

--- Comment #2 from Julian Seward <jsew...@acm.org> ---
The patch looks sane to me.  For adding spec rules like this, I use
the following testing strategy:

* first, slightly mis-implement it.  For example, do Iop_Shr64 of 62
  bits instead of 63.

* then check that your test program (or at least, _some_ program)
  crashes or fails bizarrely, with this "fix"

* then change it so it's really correct and check that said program
  now works correctly.

This gives at least some confidence that the spec rule is being used
and is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to