https://bugs.kde.org/show_bug.cgi?id=398012
Bug ID: 398012
Summary: privatize + document Notifier ctor
Product: frameworks-networkmanager-qt
Version: unspecified
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: minor
Priority: NOR
Component: general
Assignee: jgrul...@redhat.com
Reporter: sit...@kde.org
CC: lamar...@kde.org, lukas.ti...@merlin.cz
Target Milestone: ---
NetworkManager::Notifier() should be declared Q_DECLARE_PRIVATE. There is no
use case for API consumers to construct their own notifier and doing so will
give them no notifications.
NB: this is a source incompatible change. I am not sure it matters but since we
promise source compatibility this is probably material for KF6 (may check with
David Faure to make sure though)
As a stop-gap measure it'd be super useful if the class documentation of
Notifier said that one should use ::notifier() to get the singleton Notifier
instance to get notifications from.
--
You are receiving this mail because:
You are watching all bug changes.
