https://bugs.kde.org/show_bug.cgi?id=343371

Simon Depiets <sdepi...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/lok
                   |                            |alize/b6f3151185b746092ad1b
                   |                            |2e2ede5130e02c9dc02
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Simon Depiets <sdepi...@gmail.com> ---
Git commit b6f3151185b746092ad1b2e2ede5130e02c9dc02 by Simon Depiets.
Committed on 29/08/2018 at 02:10.
Pushed by sdepiets into branch 'master'.

Fix project model issues on file changes

Summary:
This revision fixes some issues with the Project Model refreshes
- Project view jumps to new (random?) file after closing translation file
https://bugs.kde.org/show_bug.cgi?id=348757
- Whole project is refreshed when a file is changed
https://bugs.kde.org/show_bug.cgi?id=343371
- Moving or adding a file/folder into the project root will trigger a bug where
only that file/folder is displayed

It mostly fixes behaviors which are applied to directories while they shouldn't
(like cache requests for directories that return empty values, or unnecessary
full regeneration).
Related: bug 348757

Test Plan:
I've tested the following test matrix :
* Move/Add/Remove/Save   x    File or Folder
* Within the root folder, within subfolders (same or different), between the
root and a subfolder

This is for a .po project architecture, I would be interested to know if the
behavior doesn't create regressions with a .po/.pot or other architecture
(which might be more buggy to begin with).

Reviewers: ltoscano, #localization, aacid, mlaurent

Tags: #localization

Differential Revision: https://phabricator.kde.org/D15049

M  +29   -13   src/project/projectmodel.cpp

https://commits.kde.org/lokalize/b6f3151185b746092ad1b2e2ede5130e02c9dc02

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to