https://bugs.kde.org/show_bug.cgi?id=266141
Albert Astals Cid <aa...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDSINFO |RESOLVED
Latest Commit| |https://commits.kde.org/kar
| |chive/524805b3ea2ebfc0a7c4a
| |3f2fb89dc8371a66e5c
Resolution|WAITINGFORINFO |FIXED
--- Comment #4 from Albert Astals Cid <aa...@kde.org> ---
Git commit 524805b3ea2ebfc0a7c4a3f2fb89dc8371a66e5c by Albert Astals Cid, on
behalf of Rinat Ibragimov.
Committed on 28/08/2018 at 21:50.
Pushed by aacid into branch 'master'.
handle non-ASCII encodings of file names in tar archives
Summary:
As UTF-8 may use multiple bytes per character, it's required to measure encoded
file name length in bytes, not just in characters. It's possible to
accidentally truncate file name if its name in characters is shorter that 100,
but in bytes — longer than 100. Also, checksum calculation must be performed on
unsigned bytes. Otherwise bytes in range 0x80-0xff when promoted to int become
negative.
Reviewers: dfaure, kossebau
Reviewed By: dfaure
Subscribers: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14674
M +49 -0 autotests/karchivetest.cpp
M +2 -0 autotests/karchivetest.h
A +0 -0 autotests/tar_non_ascii_file_name.tar.gz
M +10 -10 src/ktar.cpp
https://commits.kde.org/karchive/524805b3ea2ebfc0a7c4a3f2fb89dc8371a66e5c
--
You are receiving this mail because:
You are watching all bug changes.
