https://bugs.kde.org/show_bug.cgi?id=397338
Fabian Vogt <fab...@ritter-vogt.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/6e5c9e9b16666
| |cea60f8d95f33dfd2664c7ea626
--- Comment #5 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit 6e5c9e9b16666cea60f8d95f33dfd2664c7ea626 by Fabian Vogt.
Committed on 22/08/2018 at 12:19.
Pushed by fvogt into branch 'master'.
Use QJSValue as method parameter type for the scripting interface
Summary:
If a slot or Q_INVOKABLE has a QVariant as parameter and gets called
from a QJSEngine's script, it receives a QJSValue wrapped as QVariant.
To get a QVariant with the actual value wrapped, calling QJSValue::toVariant
is necessary.
I'm not entirely sure whether this is intentional behaviour of QJSEngine, but
even if it's a bug we'll have to workaround it.
Test Plan: I have favorites in kickoff again.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14822
M +10 -10 shell/scripting/applet.cpp
M +5 -4 shell/scripting/applet.h
M +2 -2 shell/scripting/configgroup.cpp
M +2 -1 shell/scripting/configgroup.h
M +1 -1 shell/scripting/scriptengine_v1.cpp
https://commits.kde.org/plasma-workspace/6e5c9e9b16666cea60f8d95f33dfd2664c7ea626
--
You are receiving this mail because:
You are watching all bug changes.
